search

legumeinfo / jekyll-starter-legumeinfo

A Jekyll site that demonstrates how to use the legumeinfo Jekyll theme
Apache License 2.0
1 stars 1 forks source link

Updates theme to version 1.0.0 #15

Closed alancleary closed 6 months ago

alancleary commented 6 months ago

This includes replacing removing pages that are trivial to implement (e.g. contact) and adding pages that demonstrate specific theme functionality (e.g. web components).

svengato commented 6 months ago

It looks like I can delete the untracked uikit subdirectory from the (local) theme?

alancleary commented 6 months ago

It looks like I can delete the untracked uikit subdirectory from the (local) theme?

Yes. Follow these steps if you want to be sure you're updating the theme correctly: https://github.com/legumeinfo/jekyll-theme-legumeinfo/pull/75#issuecomment-1889677040

svengato commented 6 months ago

Yes. Follow these steps if you want to be sure you're updating the theme correctly:

Except git checkout uikit-updates is now git checkout main.

svengato commented 6 months ago

I built the starter site with both bundle exec jekyll serve and docker compose up -d, it looks fine in both cases. In the former case, it modified my Gemfile.lock. Anything special I should look for?

alancleary commented 6 months ago

I built the starter site with both bundle exec jekyll serve and docker compose up -d, it looks fine in both cases. In the former case, it modified my Gemfile.lock. Anything special I should look for?

Can you share the diff on the Gemfile.lock? This PR already includes the necessary updates.

svengato commented 6 months ago

Can you share the diff on the Gemfile.lock?

Not working now - I think I broke it by running sudo bundle install. Any quick fixes for that?

svengato commented 6 months ago

Found it in the history -

diff --git a/Gemfile.lock b/Gemfile.lock
index f3bdb60..e4cb3aa 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -56,16 +56,16 @@ GEM
     pathutil (0.16.2)
       forwardable-extended (~> 2.6)
     public_suffix (5.0.4)
+    rake (13.1.0)
     rb-fsevent (0.11.2)
     rb-inotify (0.10.1)
       ffi (~> 1.0)
     rexml (3.2.6)
     rouge (4.2.0)
     safe_yaml (1.0.5)
-    sass-embedded (1.69.5-aarch64-linux-gnu)
-      google-protobuf (~> 3.23)
-    sass-embedded (1.69.5-x86_64-linux-gnu)
+    sass-embedded (1.69.5)
       google-protobuf (~> 3.23)
+      rake (>= 13.0.0)
     terminal-table (3.0.2)
       unicode-display_width (>= 1.1.1, < 3)
     unicode-display_width (2.5.0)
svengato commented 6 months ago

Fixed the problem by

bundle config set --local path 'vendor/bundle'

and trying again. The diff is the same as above.