updates to example data files that should work with the theme updates

[adf-ncgr]

I haven't tested anything!

[sammyjava]

Ummmm it looks like jekyll-starter-legumeinfo does not have the jekyll-theme-legumeinfo from GitHub as its theme - it's a local theme like the LIS site used to be. You want me to wrangle that? I didn't notice since I always test against my dev jekyll-legumeinfo instance rather than the starter site (which I've never touched, TBH).

[adf-ncgr]

Sounds like a question for @alancleary I don't think this would be anything I had touched (and I'm paying half-attention to this at the moment while on an unrelated call...)

[alancleary]

Ummmm it looks like jekyll-starter-legumeinfo does not have the jekyll-theme-legumeinfo from GitHub as its theme - it's a local theme like the LIS site used to be. You want me to wrangle that? I didn't notice since I always test against my dev jekyll-legumeinfo instance rather than the starter site (which I've never touched, TBH).

What do you mean? The theme is a submodule of the starter repo and is specified in _config.yml.

[sammyjava]

Hrm you're right, I musta had an old/botched copy. Never mind, now testing. :)

[alancleary]

This seems to be working with the bug fix introduced in theme PR #45. I'll officially review this PR once that one is merged.

[sammyjava]

Are we deviating for the starter site from the kind of data that is being generated on the jekyll-legumeinfo site? Because that works fine, or at least seems to work fine, other than that warning that I mentioned today, which seems to be new. I ran the data-generating script today on the dev site and it seems to be fine.

[adf-ncgr]

No, I think this is my bad. I seem to have a bunch of uncommitted changes to the _data files that are probably the same ones I had originally added under the theme. Stand by.

[adf-ncgr]

OK hopefull e8bebc1 did the needful to make everything work. Let me know if not.

[sammyjava]

Well I did a clean clone of the starter site along with the theme; switched the starter site to example_data_update and switched the theme to goodbye_data. Got this, not too unexpected, I think we need that file_exists update merged in.

       Jekyll Feed: Generating feed for posts
  Liquid Exception: Liquid syntax error (line 39): Unknown tag 'file_exists' in taxa/arachis/index.html
                    ------------------------------------------------
      Jekyll 4.2.0   Please append `--trace` to the `serve` command 
                     for any additional information or backtrace. 
                    ------------------------------------------------
/usr/share/gems/gems/liquid-4.0.3/lib/liquid/block.rb:38:in `unknown_tag': Liquid syntax error (line 39): Unknown tag 'file_exists' (Liquid::SyntaxError)

[alancleary]

I think we need that file_exists update merged in.

Correct. If you checkout the taxon-file-exists-fix branch as the starter's theme things appear to be working as expected.

[sammyjava]

That includes the goodbye-data update, though? We've got dueling branches here, I'm testing the goodbye-data branch on the theme. Anyway if you like it, approve it.

[alancleary]

That includes the goodbye-data update, though? We've got dueling branches here, I'm testing the goodbye-data branch on the theme. Anyway if you like it, approve it.

goodbye_data was already merged in the theme and is included in the taxon-file-exists-fix PR. I was waiting for you to confirm that the most recent commit to taxon-file-exists-fix works for you before merging.

[alancleary]

Okay, I got it now. starter:example_data_update against theme:taxon-file-exists-fix works fine.

Thanks for verifying it works; PR merged!