search

legumeinfo / jekyll-starter-legumeinfo

A Jekyll site that demonstrates how to use the legumeinfo Jekyll theme
Apache License 2.0
1 stars 1 forks source link

manifest.json missing #8

Closed nathanweeks closed 11 months ago

nathanweeks commented 11 months ago

bundle exec jekyll build (tried both in a codespace & locally with docker compose up) doesn't appear propagate the manifest.json from the theme to the resulting _site directory. I'm not sure if that's an issue with the theme or this starter site.

alancleary commented 11 months ago

I was unable to replicate this with a fresh copy of the repo using docker compose. Can you provide more details?

nathanweeks commented 11 months ago 
$ git clone --recursive https://github.com/legumeinfo/jekyll-starter-legumeinfo
...
$ cd jekyll-starter-legumeinfo
$ docker compose up
... navigate to http://localhost:4000 in web browser ...
        LiveReload: Browser connected
...
        ERROR `/manifest.json' not found.
.... <CTRL-C>
$ ls -1 _site 
404.html
CODE_OF_CONDUCT.md
LICENSE
README.md
assets
community
contact
download
events
feed.xml
help
index.html
news
taxa
tools

The web browser (Chrome) console contains GET http://localhost:4000/manifest.json 404 (Not Found)

alancleary commented 11 months ago

I'm still not getting the `/manifest.json' not found error, but I am getting the 404. I think this file is a vestige of the fact that I derived the theme from a web app built with UIkit and it isn't actually necessary for our website since it's not a web app. Is there a specific use case you need it for? If not the solution here may be to just remove it.

nathanweeks commented 11 months ago

I'm still not getting the `/manifest.json' not found error, but I am getting the 404.

To clarify, ERROR/manifest.json' not found.was logged by thejekyll serve` after a web browser visits http://localhost:4000 and attempts to access /manifest.json.

I think this file is a vestige of the fact that I derived the theme from a web app built with UIkit and it isn't actually necessary for our website since it's not a web app. Is there a specific use case you need it for? If not the solution here may be to just remove it.

Thanks for the background info. I don't have a specific use case; if you think it's unnecessary, then it can probably be removed from the theme.

alancleary commented 11 months ago

I don't have a specific use case; if you think it's unnecessary, then it can probably be removed from the theme.

OK, I'll open an issue in the theme to remove it.

alancleary commented 11 months ago

Won't fix. See issue #51 in the theme for details.