search

legumeinfo / jekyll-starter-legumeinfo

A Jekyll site that demonstrates how to use the legumeinfo Jekyll theme
Apache License 2.0
1 stars 1 forks source link

favicon.ico 404 #9

Closed nathanweeks closed 10 months ago

nathanweeks commented 11 months ago

The theme expects favicon.ico to be at /assets/favicon.ico:

docker compose up
... point browser to http://localhost:4000 ...
ERROR `/assets/favicon.ico' not found.

This starter site has the favicon at /assets/icons/favicon.ico

alancleary commented 11 months ago

Mind opening a PR for this one?

In general the theme should be checking if the various icon files existing and only adding link tags for them if they do. I'll open an issue in the theme repo for that. Edit: See issue #52.

alancleary commented 10 months ago

This was addressed in theme PR #53.