search

legumeinfo / jekyll-theme-legumeinfo

A Jekyll theme for the Legume Information System and related biodata websites
https://www.legumeinfo.org/
Apache License 2.0
1 stars 1 forks source link

Add alt text to site logo #102

Closed nathanweeks closed 1 month ago

nathanweeks commented 2 months ago

Could be based on the site title, or maybe just "site logo".

alancleary commented 2 months ago

I think "site logo" makes sense since that's what we call the image in the config. Speaking of the config, do you think it would be worth making this alt text configurable via the _config.yml file?

nathanweeks commented 2 months ago

From this W3C example, I guess might make sense to default to alt="{{ site.title }} home" instead?

I don't have a strong opinion on whether or not to allow the alt text for the site logo to be customized in _config.yml, or require the user to override navbar.html if they have a strong opinion on the alt text.

alancleary commented 2 months ago

@nathanweeks If it's good enough for W3C then it's good enough for me; let's skip the user config and just implement the alt text from your example. Mind making a PR for this?