search

legumeinfo / jekyll-theme-legumeinfo

A Jekyll theme for the Legume Information System and related biodata websites
https://www.legumeinfo.org/
Apache License 2.0
1 stars 1 forks source link

Fix liquid syntax error #60

Closed nathanweeks closed 10 months ago

nathanweeks commented 10 months ago

Setting the liquid error_mode: strict in a Jekyll _config.yml reveals a syntax error at this line (Expected end_of_string but found pipe in "item in group.items | sort: "name""). Proposing to fix the syntax error by removing the attempted sort, and leaving the tool ordering as specified in tools.yml

alancleary commented 10 months ago

@nathanweeks does this resolve issue #25?

nathanweeks commented 10 months ago

Unfortunately no---the workaround (described in https://github.com/Shopify/liquid/issues/1034#issuecomment-590121750) involves changing tests for variable existence like:

{% if page.tools_menu ...

to use the contains operator instead:

{% if page contains "tools_menu" ...

Not technically difficult, just would need to be done in a number of places.

alancleary commented 10 months ago

Unfortunately no---the workaround (described in Shopify/liquid#1034 (comment)) involves changing tests for variable existence like:

{% if page.tools_menu ...

to use the contains operator instead:

{% if page contains "tools_menu" ...

Not technically difficult, just would need to be done in a number of places.

Ah, that's right. Sorry for the dumb question!