legumeinfo / jekyll-theme-legumeinfo

A Jekyll theme for the Legume Information System and related biodata websites
https://www.legumeinfo.org/
Apache License 2.0
1 stars 1 forks source link

UIkit symlinks #71

Closed alancleary closed 9 months ago

alancleary commented 10 months ago

Despite the most recent commit message for each of the UIkit files in the assets/ directory, these assets are actually hard copies of the files rather than symlinks to the files in the uikit submodule. This means updating the submodule could introduce changes to the styling that's incompatible with the hard copies. Fix this by replacing the hard copies with symlinks.

Also, the uikit submodule isn't included in the spec.files regular expression in the jekyll-theme-legumeinfo.gemspec file, meaning if/when the theme is made into a gem the UIkit submodule won't be included and none of the symlinks will work. Fix this!

alancleary commented 9 months ago

Done in PR #75.