The gemspec file should specify what plugins the theme needs and what versions of Jekyll the theme is compatible with. Currently the gemspec file says it requires version 4.2 of the jekyll gem, which is too specific. Instead this should be a range of versions the theme is compatible with so sites using the theme don't all have to use the same version of Jekyll; see the minima theme's gemspec file for an example. Also, the theme's gemspec file lists webrick as a dependency. This is not require for all versions of ruby and when it is required the version may depend on what version of Jekyll in installed. Therefor this dependency should be removed.
Edit: The theme heavily relies on the pre-configuration functionality introduced in Jekyll 4. The theme can still be used with earlier versions of Jekyll but it should be noted in the README.md that sites using an earlier version will need to manually add some of the theme's configurations to the site's _config.yml file.
alancleary
commented
9 months ago
The gemspec file should specify what plugins the theme needs and what versions of Jekyll the theme is compatible with. Currently the gemspec file says it requires version
4.2of thejekyllgem, which is too specific. Instead this should be a range of versions the theme is compatible with so sites using the theme don't all have to use the same version of Jekyll; see the minima theme's gemspec file for an example. Also, the theme's gemspec file listswebrickas a dependency. This is not require for all versions of ruby and when it is required the version may depend on what version of Jekyll in installed. Therefor this dependency should be removed.Edit: The theme heavily relies on the pre-configuration functionality introduced in Jekyll 4. The theme can still be used with earlier versions of Jekyll but it should be noted in the
README.mdthat sites using an earlier version will need to manually add some of the theme's configurations to the site's_config.ymlfile.