search

legumeinfo / jekyll-theme-legumeinfo

A Jekyll theme for the Legume Information System and related biodata websites
https://www.legumeinfo.org/
Apache License 2.0
1 stars 1 forks source link

Post related content #95

Closed alancleary closed 7 months ago

alancleary commented 8 months ago

The blog, news, and events are all "post" content, yet they were all being presented in a stylistically inconsistent way. This PR uses Jekyll layouts and includes to clean that up. Reviewers should specifically look at the post card widgets on the homepage, the post landing pages, and the specific post pages for blog, news, and events content.

adf-ncgr commented 7 months ago

@alancleary regarding stylistic consistency, the only thing I've noticed is that the blog card does not seem to display dates for the posts. Is that intentional or the sort of thing you were hoping a reviewer would pick up on? Other than that, I see no other inconsistencies or issues.

alancleary commented 7 months ago

@alancleary regarding stylistic consistency, the only thing I've noticed is that the blog card does not seem to display dates for the posts. Is that intentional or the sort of thing you were hoping a reviewer would pick up on? Other than that, I see no other inconsistencies or issues.

It's intentional. My rationale was that blog posts are timeless compared to news and events, so using precious space in the card for a gratuitous date seemed like bad style. The post date and author are listed in the blog landing page and when viewing a specific post. I can add back the date if you think it's worthwhile.

adf-ncgr commented 7 months ago

OK, that's fine with me; one approval coming up...