search

legumeinfo / jira-issues

placeholder repo for issues migrating from JIRA system, to be moved to their appropriate places later
0 stars 0 forks source link

tripal_phylotree: organism abbreviations changed in new database load #43

Closed adf-ncgr closed 10 years ago

adf-ncgr commented 10 years ago

The javascript in my module should not depend on the organism abbreviation for color-coding the legumes in the d3js charts, because that's brittle. Use organism_id instead, and dynamically generate the color lookup table from database query. We need an is_legume column somewhere in the database :/

[LEGUME-75] created by agr

adf-ncgr commented 10 years ago

Hi Alex-
as we just discussed, let's rely on the organism table's genus and species fields since this should be more stable (especially if we end up make this module usable for other groups who may have other ideas on how to abbreviate)

adf

by adf_ncgr

adf-ncgr commented 10 years ago

OK fixed
https://github.com/ncgr/tripal_phylotree/commit/51803ff02d9604498ed85f7dd2d1ab269ecac84d

by agr