legumeinfo / microservices

A collection of microservices developed and maintained by the Legume Information System
https://legumeinfo.org/
Apache License 2.0
3 stars 2 forks source link

Gene linkouts Soybase URL is broken #598

Open sammyjava opened 1 year ago

sammyjava commented 1 year ago

glyma.Wm82.gnm2.ann1.Glyma.01G103400

generates linkouts with Soybase URL lacking gene identifier:

http://www.soybase.org/sbt/search/search_results.php?category=FeatureName&search_term={UNPREFIXED_GENE_ID}

adf-ncgr commented 1 year ago

thanks - this linkout is no longer in the yaml, but until we get a service running on the updated ones it will persist. Alternatively, I could commit the code that was dealing with substituting in the UNPREFIXED_GENE_ID but that will also require a service instance to be deployed. Sounds like @nathanweeks was OK with us managing the service from our end, so I guess we need to decide if that means re-pointing linkouts.services.legumeinfo.org to the NCGR production host or just coining a new endpoint like services.lis.ncgr.org that doesn't require DNS tinkering on the ISU side. Any preferences?

sammyjava commented 1 year ago

Not per this particular case, but it's a higher-level question regarding hosts. Should all legumeinfo.org sites and services consume services only on legumeinfo.org? Or is lis.ncgr.org a suitable domain for production services? I don't have any issue with hosting services on lis.ncgr.org but are there some USDA issues? That's my only concern. Otherwise I prefer to use lis.ncgr.org so we have control over the DNS, as you say. But it should only be for services behind the scenes: end users should use legumeinfo.org hosts in their browsers.

sammyjava commented 1 year ago

Actually, come to think of it, a CNAME doesn't really change anything, I think, from the USDA perspective - I'd think it's more about the IP segment - so let's go ahead and run our services on lis.ncgr.org. Unless folks in Iowa have a problem with it.