search

legumeinfo / microservices

A collection of microservices developed and maintained by the Legume Information System
https://legumeinfo.org/
Apache License 2.0
3 stars 2 forks source link

added linkout services for gene families and pan gene sets. #613

Closed adf-ncgr closed 6 months ago

adf-ncgr commented 6 months ago

to support linkouts for new (pangeneset) and existing (genefamily) columns in the gene search component (and elsewhere, e.g. GCV can use them)

adf-ncgr commented 6 months ago

FYI when you tag a release for this make sure that the versions in the linkouts/linkouts/__init__.py and compose.prod.yml files match each other and what's tagged. Currently linkouts/linkouts/__init__.py says 1.0.1 but compose.prod.yml says 1.0.0, and the only version that has been tagged is 1.0.0.

thanks for spotting that, I will update compose.prod.yml and release as 1.0.1 ( I think I'd bumped init.py a long time ago and maybe only pushed the unrelated change corresponding to it as part of this).

regarding testing, I satisfied myself that it's working as intended; someday you can insist on a unit test when there's a framework in place...

alancleary commented 6 months ago

someday you can insist on a unit test when there's a framework in place...

Hopefully this day will come soon!

alancleary commented 6 months ago

@adf-ncgr I'm not sure if the "upcoming release" you mentioned in your last commit includes these changes, but if it does I think the version should be 1.1.0, not 1.0.1, since this PR adds new features.