search

legumeinfo / mine-issues

Report ALL issues on LIS mines here! Regardless of which mine you found it on!
2 stars 0 forks source link

Stop loading phylotrees? #139

Closed sammyjava closed 11 months ago

sammyjava commented 11 months ago

Lately I've been skipping the phylotree loader on MiniMine because we've got a linkout to Funnotate. I'm wondering - is there any reason to store the phylotrees in the mines? Are we actually querying them from the mines? We've got linkouts to the trees in a much more useful display.

"View Funnotate phylogram for family of ..." image

sammyjava commented 11 months ago

Also note that the Gene Family report page has a direct attribute link to Funnotate. image

alancleary commented 11 months ago

Yes. The phylotree web component my summer intern implemented uses it via GraphQL. This hasn't been merged into main yet but I am very much still planning to finish it up and deploy it on the site.

Alan

sammyjava commented 11 months ago

AH forgot about that. Then we'll keep them in the mines!

adf-ncgr commented 11 months ago

@alancleary can you confirm whether that simply requests the Newick string? If so, it might still be possible for @sammyjava to simplify what he's loading (not parsing the trees into Phylonodes with inter-relations). Maybe that is not a big win, though.

sammyjava commented 11 months ago

I can also probably speed up the loader. The Newick text is the bulk of the data since the other two classes are just relations and identifiers.

adf-ncgr commented 11 months ago

OK, I'm happy to keep fully parsed trees if you are.

sammyjava commented 11 months ago

For sure, just checking on what needs to stay in the garage. :)