legumeinfo / mine-issues

Report ALL issues on LIS mines here! Regardless of which mine you found it on!
2 stars 0 forks source link

Remove unneeded core post-processors #140

Open sammyjava opened 11 months ago

sammyjava commented 11 months ago

Revelation: after looking through the core post-processors (to optimize them) I realize that three are doing nothing that isn't already being done in the LIS loaders. So, yank 'em from all the project.xmls:

Note: In the meantime I seem to have vastly sped up populate-child-features using a parallel stream. This post-processor exists to populate the childFeatures collection that is sent to JBrowse; it has no other purpose. I think that collection is already fully populated by the LIS annotation GFF loader, but there's no harm in continuing to use it since it's decently fast now. On the other hand, it could be tweaked to change how the JBrowse displays subfeatures (or do so in the GFF loader and skip populate-child-features).

sammyjava commented 11 months ago

I'm removing two more, as they don't seem to do anything that's not done in the loaders.

I'll add that create-utr-references expects an MRNA.fivePrimeUTR and MRNA.threePrimeUTR reference, which I don't think are needed since we have the Transcript.UTRs collection (following the SO). I don't think those references are used anywhere. The GFF loader does add the two UTRs to the MRNA.childFeatures collection, which is used by the JBrowse.