search

legumeinfo / mine-issues

Report ALL issues on LIS mines here! Regardless of which mine you found it on!
2 stars 0 forks source link

GlycineMine unfriendliness to other mines #173

Open adf-ncgr opened 1 week ago

adf-ncgr commented 1 week ago

per @maxglycine, GlycineMine is not returning results for "links to other mines" on the gene report pages of other mines and is not receiving "links to other mines" from any of the others. This likely is some sort of configuration issue.

adf-ncgr commented 1 week ago

actually, that change has made glycinemine friendlier to other mines, but other mines seem to still be unfriendly to it. The browser console has a variety of errors, which probably suggest what else remains to be done to fix this.

svengato commented 1 week ago

Still trying to figure out what you changed, some of the libraries have changed but there must be source file(s) as well? And this was only in production?

adf-ncgr commented 1 week ago

see the commit linked above; it's in the github but only deployed on production at the moment.

svengato commented 1 week ago

That only changed a comment, so would anything really have changed?

adf-ncgr commented 1 week ago

the line below that was also different in the file. Maybe it had already been changed in the github, I didn't think to do a git pull, assuming the local files were already up-to-date

svengato commented 1 week ago

Is this correct?

friendlymines.linkgenerator = org.ncgr.intermine.bio.web.displayer.FriendlyMineLinkGenerator
adf-ncgr commented 1 week ago

I think so, I just copied the value another properly working mine had there.

adf-ncgr commented 1 week ago

actually, I am pretty confused by the current behaviors. AFAICT the other genus mines are also not getting much friendliness (ie it does not seem to be limited to glycinemine), but LegumeMine is getting most of the mines to be friendly with it (except GlycineMine, though possibly the unfriendliness is sporadic, I have seen it return results to LegumeMine).

svengato commented 1 week ago

These production mines are missing that friendlymines.linkGenerator= line: ArachisMine, LupinusMine.

svengato commented 1 week ago

This does not affect GlycineMine, but some of the mines did not update their friendly mines from common names to genus names.

adf-ncgr commented 1 week ago

yes, I noticed that too; we should fix it, though it doesn't seem to be the only problem (I think I may have already committed but not yet pushed an update on GlycineMine to address a couple that it didn't have right)

svengato commented 1 week ago

GlycineMine's webapp/src/main/web.properties has a swap file, are you in the middle of editing it?

svengato commented 1 week ago

Also, should a mine include itself as a friendly mine? It looks like some do and some do not.

adf-ncgr commented 1 week ago

GlycineMine's webapp/src/main/web.properties has a swap file, are you in the middle of editing it?

no, but I did have it open.

adf-ncgr commented 1 week ago

Also, should a mine include itself as a friendly mine? It looks like some do and some do not.

I'm not sure. Some mines being friendly to themselves might make sense but others (legumemine) would likely be unhelpful. For now, let's just leave as is.

adf-ncgr commented 1 week ago

I'm starting to get the impression that the issue may be one caused by a data loading change. It seems like the current implementation can only find friends if it itself knows about their genes. This is true of legumemine and possibly was true of the other mines (e.g. Arachismine might have previously had shallow knowledge of what genes from other genera were present in the gene family, but it does not now). I suspect this may have been a change that Sam made without noticing the consequences. This is still very much a theory, but would seem to explain the asymmetric behavior.

svengato commented 1 week ago

I can look through Sam's change history, though mixed in with other tasks so as to avoid InterMine stress syndrome.