lehaifeng / T-GCN

Temporal Graph Convolutional Network for Urban Traffic Flow Prediction Method
1.43k stars 446 forks source link

have you tested baseline.py? #4

Closed KingWang93 closed 3 years ago

KingWang93 commented 5 years ago

some errors exist during runing

lehaifeng commented 5 years ago

We have tested it on our computer, and didn't find problems. Would you please give me more information to address the issues?

Thanks for your attention.

KingWang93 commented 5 years ago

We have tested it on our computer, and didn't find problems. Would you please give me more information to address the issues?

Thanks for your attention.

have you tested the method "HA " when the pre_len>1?

lehaifeng commented 5 years ago

Hi, I have update the baseline.py and add some annotations.

Hope it's useful to you.

ldacosta commented 5 years ago

Hi. While running baselines.py on los dataset I get the error

ValueError: Found input variables with inconsistent numbers of samples: [1552, 388]

You mentioned here that you updated the file on March 9th, but the date on the file is Feb 2. Would this be the source of the error?

ldacosta commented 5 years ago

Sorry. Forgot to mention that the error above is for method HA

lehaifeng commented 5 years ago

HI Luis, thanks for your attention.

Would you please check your data. For example, check your X and Y if they have the same length.

On Thu, Jun 20, 2019 at 5:01 AM Luis Da Costa notifications@github.com wrote:

Sorry. Forgot to mention that the error above is for method HA

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/lehaifeng/T-GCN/issues/4?email_source=notifications&email_token=ACVTXTBLI22W5QW5IG4TFW3P3KNCXA5CNFSM4G2ID6Q2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYDIUCA#issuecomment-503745032, or mute the thread https://github.com/notifications/unsubscribe-auth/ACVTXTCVMHG4E3FEOBJCBJDP3KNCXANCNFSM4G2ID6QQ .

-- Haifeng Li, Ph.D. Associate Professor School of Civil Engineering and Architecture Central South University 22 Shaoshan South Road, Changsha, 410004, P.R.China Tel: +86-15608418565 Email: lihaifeng@csu.edu.cn URL: www.csu.edu.cn/english/index.htm http://www.csu.edu.cn/english/index.htm

ldacosta commented 5 years ago

Hi @lehaifeng . I am using the datasets provided by you on this repo. In this specific example is for the los file.

ldacosta commented 5 years ago

Here is my output:

(T-GCN) ~/dev/T-GCN (master) $  python baselines.py 
Traceback (most recent call last):
  File "baselines.py", line 58, in <module>
    rmse, mae, accuracy,r2,var = evaluation(testY1, result1)  
  File "baselines.py", line 29, in evaluation
    rmse = math.sqrt(mean_squared_error(a,b))
  File "python3.6/site-packages/sklearn/metrics/regression.py", line 239, in mean_squared_error
    y_true, y_pred, multioutput)
  File "python3.6/site-packages/sklearn/metrics/regression.py", line 75, in _check_reg_targets
    check_consistent_length(y_true, y_pred)
  File "python3.6/site-packages/sklearn/utils/validation.py", line 235, in check_consistent_length
    " samples: %r" % [int(l) for l in lengths])
ValueError: Found input variables with inconsistent numbers of samples: [1167, 389]
github-actions[bot] commented 3 years ago

This issue is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 3 days.

github-actions[bot] commented 3 years ago

This issue was closed because it has been stalled for 3 days with no activity.