lehaithanh10 / ESPF-Bot-Test

0 stars 0 forks source link

Test post proposal to external help wanted issue #1

Open lehaithanh10 opened 1 year ago

lehaithanh10 commented 1 year ago

Action Performed:

  1. Copy some alphabetical text (i.e.: Abcd)
  2. Go to split bill
  3. Paste the copied text in split bill amount

Expected Result:

Split should restrict alphabets completely

Actual Result:

Split bill shows alphabets for a bit when pasted.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.11-2 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation

https://user-images.githubusercontent.com/43996225/236699096-3f36ac00-ddcc-4a94-b1b1-bca06900c17e.MP4

https://user-images.githubusercontent.com/43996225/236699104-3a2867c4-b15f-4e47-8f70-92e3294a07f9.MP4

Expensify/Expensify Issue URL: Issue reported by: @DinalJivani Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1683416584966559

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01569ec2d58fbfa63f
  • Upwork Job ID: 1655626738889830400
  • Last Price Increase: 2023-05-16
dukenv0307 commented 1 year ago

abc

dukenv0307 commented 1 year ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

No padding below in add personal message on adding of new line on web

What is the root cause of that problem?

No padding bottom of TextInput if it has multiple line. https://github.com/Expensify/App/blob/74d5290dd95500b86f8b4f384b18b9aca87364a2/src/components/TextInput/BaseTextInput.js#L293

What changes do you think we should make in order to solve the problem?

Add styles.pb1 after (!hasLabel || this.props.multiline) && styles.pv0 to set padding bottom of TextInput if it has multiple line

What alternative solutions did you explore? (Optional)

NA

Result

Screencast from 17-04-2023 17:34:57.webm

dukenv0307 commented 1 year ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

No padding below in add personal message on adding of new line on web

What is the root cause of that problem?

No padding bottom of TextInput if it has multiple line. https://github.com/Expensify/App/blob/74d5290dd95500b86f8b4f384b18b9aca87364a2/src/components/TextInput/BaseTextInput.js#L293

What changes do you think we should make in order to solve the problem?

Add styles.pb1 after (!hasLabel || this.props.multiline) && styles.pv0 to set padding bottom of TextInput if it has multiple line

What alternative solutions did you explore? (Optional)

NA

Result

Screencast from 17-04-2023 17:34:57.webm