search

lehaos / sms-pdu

Automatically exported from code.google.com/p/sms-pdu
0 stars 0 forks source link

error in type of phone number(81 or 91) #6

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
line 278 in SMSBase.cs, function EncodePhoneNumber
"int header = (phoneNumber.Length << 8) + 0x81 | (isInternational ? 0x10 : 
0x20);"

Code "0x81 | (isInternational ? 0x10 : 0x20);" result in 0x91 for international 
numbers and 0xA1 for others, bu it is not correct:
http://www.developershome.com/sms/cmgwCommand.asp
"The second parameter of the +CMGW AT command, address_type.... They are 
129(0x81) and 145(0x91)..."

I consider that correct is:
"int header = (phoneNumber.Length << 8) + (isInternational ? 0x91 : 0x81);"

Thank you...

Original issue reported on code.google.com by mbo...@gmail.com on 15 Aug 2013 at 9:07

GoogleCodeExporter commented 8 years ago 
Confirm this issue and solution that is proposed

Original comment by milanbet...@gmail.com on 17 Feb 2015 at 9:49