search

lehh / nestjs-soap

Nestjs module wrapper for soap npm package
MIT License
21 stars 15 forks source link

Feat/add register async #5

Closed kleberoliveira closed 3 years ago

kleberoliveira commented 3 years ago

Hi @lehh, I created new approaches for async methods to inject other modules when importing the SoapModule. Also, I put the Auth basic as an option to start the soap client already authenticated.

It's hard for me to create the unit test, but I got 90% of coverage, I think that's enough :)

lehh commented 3 years ago

Hello @kleberoliveira, thanks a lot for the pull request. Could you please update the README with the new features too? After that I will merge the pull request and publish the package.

kleberoliveira commented 3 years ago

@lehh done :)

lehh commented 3 years ago

Package published on npm. Thanks again!