lehjr / MachineMusePowersuits

Minecraft mod, take 3
Other
16 stars 15 forks source link

Armour not correctly working #31

Closed FC360D closed 2 years ago

FC360D commented 2 years ago

I have a every armour piece with energy shield at 100% and advance batteries however the Chest and leggings are ignored for some reason even though both have the energy shields set to 100%.

Edit: After messing around it seems to be the kinetic generator causing most of the issue as installing it onto the torso causes the armour to be removed and a -0.03 speed when worn on legs which is weird as the torso doesn't go on the leg lol. However the leggings never seem to have any armour even though it has the energy shield so not sure what's going on with that.

Santvarg commented 2 years ago

I can confirm this, chest armor with max rank battery and shield works fine, breaks when kinetic gen is equipped, shows as leg item with speed bonus but no armor bonus

Legs work up until you put sprint assist on, showing only a speed bonus for legs, but only AFTER taking a step

Both items are broken indefinitely for armor and you must make new ones debug.log latest.log 2022-01-07-2.log.gz

Here are the logs from this session:

Santvarg commented 2 years ago

Additionally, here's my modlist as I see that should be standard Numina 2.1.16, MPS 2.1.18 image

lehjr commented 2 years ago

Underlying issue is the way the attribute modifiers are applied. Setting with tags bypasses all other settings, so they have to be applied dynamically through the ItemStack sensitive method and has to be applied in a similar fashion with what I already have in the base class otherwise the effect is permanently applied to the player until the next login. I have a fix in the works, I’m just working on balancing the effect between the sprint assist and the kinetic generator.

lehjr commented 2 years ago

Fixed in latest beta