search

lehjr / MachineMusePowersuits

Minecraft mod, take 3
Other
17 stars 15 forks source link

PowerSuits breaks other armor textures #53

Open SheReyy opened 2 years ago

SheReyy commented 2 years ago

Version info Java version: 1.8.0_51 Minecraft Forge version: 36.2.21 MPS version: ModularPowersuits-1.16.5-2.1.22.jar (newer versions don't work either) Numina Version: Numina-1.16.5-2.1.22.jar (newer versions don't work either) I downgraded to this versions of the mod because in the newer ones, the Power Fist modules, don't work.

Describe the bug With Modular Powersuit, all the armors in the game, look bad. I have no idea what mod breaks Modular Powersuit, but I wanted to report this bug anyway. UPDATE: I think it's just a bug from MPS as I've tested it on a pack with very few mods in it. I'll try just with MPS to be sure. UPDATE: Yes. Bug from Modular Powersuit entirely. The Vanilla Armors look normal, but the ones from other mods, don't.

Mod list ModularPowerSuits + any mod with custom armor models, like Botania

Screenshots image image

lehjr commented 2 years ago

I'll be marking this as INVALID, since it's NOT the latest version of the mod, and not the smallest mod list needed to reproduce the issue. I simply don't have the kind of time it requires to hunt down your mods, download and install them, then eliminated them until i can no longer replicate the issue. It simply isn't feasible. I'd be spending my days doing that and the mod would be stuck in limbo.

SheReyy commented 2 years ago

I'll be marking this as INVALID, since it's NOT the latest version of the mod, and not the smallest mod list needed to reproduce the issue. I simply don't have the kind of time it requires to hunt down your mods, download and install them, then eliminated them until i can no longer replicate the issue. It simply isn't feasible. I'd be spending my days doing that and the mod would be stuck in limbo.

  1. I clearly said that this also happens on the newer versions - I've tested all of them, including - ModularPowersuits-1.16.5-2.2.24.jar.
  2. I also clearly said that this issue happens just with your mod. That large mod list was provided just so you know where the issue was initially discovered. Fine, I'll remove the mod list.
  3. Want to recreate this? Install just MPS with Atum2 and there you go. You can replace Atum2 with Botania, or any other mod which adds custom armor models and you'll have the same issue.
lehjr commented 2 years ago

You gave me a list of over 200 mods, and said, here's my list. "UPDATE: Yes. Bug from Modular Powersuit entirely. The Vanilla Armors look normal, but the ones from other mods, don't." is not the same as mods with custom armor models.

lehjr commented 2 years ago

and yes, I can see your edits.

SheReyy commented 2 years ago

You gave me a list of over 200 mods, and said, here's my list. "UPDATE: Yes. Bug from Modular Powersuit entirely. The Vanilla Armors look normal, but the ones from other mods, don't." is not the same as mods with custom armor models.

Yes, and I said that I gave you that list so you know where the issue was initially discovered. And I think it's pretty obvious that I was talking about armors with custom models, since that's the type of armors shown in the pictures that I left here.

lehjr commented 2 years ago

just because a mod has custom armor doesn't mean it has a custom armor model.

SheReyy commented 2 years ago

just because a mod has custom armor doesn't mean it has a custom armor model.

Yeah, apologies on that, apparently it was a misconception on my part. So, custom armors with vanilla models have no problem, but custom armors with custom models, do.

lehjr commented 2 years ago

Confirmed and fixed the issue. I'll have to track down the power fist issue before the next release though.

SheReyy commented 2 years ago

Confirmed and fixed the issue. I'll have to track down the power fist issue before the next release though.

Don't know if this helps, but I just discovered that the power fist issue takes place at random. I lowered the amount of mods present on my list, and I though I was getting somewhere, but to no success. Sometimes the textures are fine, and sometimes, they're missing. I could keep removing the mods until I don't see the missing textures for multiple times when I open the game, but I doubt how accurate/how useful would that be overall.

lehjr commented 2 years ago

Might be a loading order issue compounded by nearly everything being multithreaded. I’ll have to look into it a bit more.