search

lehjr / MachineMusePowersuits

Minecraft mod, take 3
Other
17 stars 15 forks source link

Configuration files do not register modified values #64

Open jiive opened 1 year ago

jiive commented 1 year ago

Version info Java version: 1.16.5 Minecraft Forge version: 36.2.39

Describe the bug I am attempting to buff the base damage of the Plasma Cannon from 2 to 4. Despite making these value changes within the configuration files themselves and even saving these modifications to the defaultconfigs folder, these changes simply don't apply themselves. I went as far as creating a clean profile in Overwolf and only installed this mod along with Numina. Same results, and modified values don't seem to apply.

To Reproduce Steps to reproduce the behavior:

  1. Download this mod and Numina.
  2. Go to [instance]/saves/[save]/serverconfig/powersuits-server.toml
  3. Modify powersuits-server.toml and save any changes.
  4. Boot up Minecraft Forge and load any save with the modified powersuits-server.toml.
  5. Observe as absolutely nothing changes despite configuration files being modified.

Expected behavior In spite of any changes to powersuits-server.toml, all values seem to remain on default.

Mod list configured-1.5.3-1.16.5 Hwyla-forge-1.10.11-B78_1.16.2 jei-1.16.5-7.7.1.153 ModularPowersuits-1.16.5-2.2.31 Numina-1.16.5-2.2.31 Pehkui-3.6.3+1.16.5-forge

Log files latest.log

jiive commented 1 year ago

Also, as a request for the configuration files, is it possible if the mod author can add a configurable charge speed for both the Plasma Cannon and the Railgun? Thanks in advance!

Omegatron9 commented 1 year ago

I had the same issue trying to change the armour values of the platings and energy shields.

lehjr commented 1 year ago

I'll have to look into the config system probably this week. I stopped porting beyond 1.16.5 for now so I can work on some issues instead of dragging them along to a new MC version. So there will probably be a couple more 1.16.5 releases before I move on to another version. Next release will have GUI changes. After that will be simplifying some of the settings and translation files, also digging into the config system to fix some things.

lehjr commented 1 year ago

Turns out the fix for that issue was relatively simple, and will be fixed in the next release. However, the server side config file will be replaced due to the issue that was plaguing the whole setup.