lehjr / MachineMusePowersuits

Minecraft mod, take 3
Other
15 stars 15 forks source link

[1.19.2] [2.3.8] Crash due to mod incompatability #93

Closed UselessRobot closed 6 months ago

UselessRobot commented 6 months ago

Version info Java version: Eclipse Adoptium - jdk-17.0.2.8-hotspot Minecraft Forge version: 43.3.7

Describe the bug The game crashes on boot when attempting to launch with this mod: https://www.curseforge.com/minecraft/mc-mods/weapon-master Appears to only be a client sided crash.

To Reproduce

  1. Boot the forge instance with both this mod, Weapon Master (version 1.4.2-1.19.2 was used specifically for my case) and numina.
  2. The game will crash while in the splash screen.

Expected behavior No crash.

Mod list Taken from crash log

Log files Crash report: https://pastebin.com/VKBaG1uZ

Edit: Corrected java version

lehjr commented 6 months ago

JDK 8 isn't supported for 1.19.2 Edit: Your log says Java Version: 17.0.2, Eclipse Adoptium

lehjr commented 6 months ago

Other mod's fault. Since capabilities are both client and server side, don't use client side only objects in capability initialization because capabilities exist on both SERVER and client. There should be no logical need to call minecraft.level.random.nextInt() during capability initialization. Plenty of other ways to generate a random integer which don't rely on client side only objects.

UselessRobot commented 6 months ago

I'll see if I can poke the devs for weapon master about it then. They're a little harder to get in touch with which was why I went here first.