search

lehmannro / assert.sh

bash unit testing framework
GNU Lesser General Public License v3.0
487 stars 57 forks source link

Incorrect name in package.json #26

Closed adamjc closed 5 years ago

adamjc commented 5 years ago

Hey dude, GitHub have a dependency management bit, and it's showing up incorrectly due to how it gets information between npm and GitHub. Your name in the package.json is assert, but that's already an npm package, so GitHub is getting super confused.

Can you remove the name field from your package.json file. I'd recommend using make or another build tool instead of npm for non-node repos.

The image below shows that there are repos with your dependency, but actually they are depending on commonjs-assert, which is what is actually aliased to that name in NPM.

Screenshot 2019-03-25 at 11 58 50

https://www.npmjs.com/package/assert <- this is what you are saying your repo is

Cheers.

lehmannro commented 5 years ago

AFAICT this was added in 51d7a0ad as a file for bpkg, not npm. I'm not sure why bpkg and npm chose the same format — and maybe that's actually a good thing — but a namespace collision between those two seems wholly inappropriate and nothing I can fix on my side.

adamjc commented 5 years ago

Ah, my bad I assumed that package.json was strictly limited to npm packages! Interesting. I'm currently trying to raise an issue with GitHub for them to fix it on their end. Thanks for getting back.