karma module exposes DoS vulnerability

lehmannro / pyhkal2

IRC bot with bling bling

7 stars 2 forks source link

karma module exposes DoS vulnerability #11

Open lehmannro opened 14 years ago

lehmannro commented 14 years ago

A query containing multiple karma modifications can cause a disproportionate amount of responses. Replies below the timeout treshold (currently implemented as karmaspam) should either remain quiet (easy) or only trigger under certain conditions (hard, because it's unclear what these conditions are).

lehmannro commented 14 years ago

Partially fixed in 767a5a50ff72f4a07782f1c11c325c183ceb58e0. There should a maximum treshold of karma modifications a single event can trigger.

obama commented 14 years ago

Or group karma output on big requests? like: "Karmawerte für affe: 32, berg: -1, pilz: 209"