Closed glormph closed 5 months ago
To clarify:
in qc_protein, all combinations of sample groups are tried to create a plot, but only some will exist (i.e. A-B but not B-A since they are identical), and here it will mistakenly find both.
In the sed with arr, it will assign the wrong sample group since multiple sets will be matched due to the overlap. This makes it wrong, and crashes DEqMS in the process.
Shouldve known better than to use a regex, this:
Will bite itself in the ass when a setname (
${arr[0]}
) is1
and another is11
for example.Could be solved by adding a
^
to mark start of string/line, but it would maybe be better to put this in msstitch?Found by Yaroslav
Second occurence in qc_protein.R:
if (length(grep(logfcname, names(feats)))) {
This returns a partial match also so if two comparisons areABC-QWER
andQWER-BC
it will return also true forBC-QWER
Need in both cases to fully match, not partial.