lehuygiang28 commented 2 months ago

Fix verify failed due to amount issue

This pull request fixes the issue by removing the division operation before verifying the signature.

fixes #15

Type of Change

Please check the type of change your PR introduces:

[x] Bugfix
[ ] New feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[x] Documentation content changes
[ ] Other (please describe):

Testing

[x] Try to convert vnp_Amount to a string. It will go directly to the if block, so it will not be divided anymore. Verify that it worked!

Does this introduce a breaking change?

[ ] Yes
[x] No

If yes, please describe the impact and migration path for existing applications:

Related Issues or References

15

Summary by Sourcery

This pull request fixes an issue with the signature verification by removing an unnecessary division operation on the amount. It also updates the 'Buy Me A Coffee' button in the documentation and adds an English translation for a comment in the type definition file.

Bug Fixes:
- Fixed incorrect signature hash during verify return URL by removing the division operation on the amount.
Documentation:
- Updated the 'Buy Me A Coffee' button in README.md and README_en-US.md with a new image and link format.
- Added English translation for the 'Payment amount' comment in the return-from-vnpay.type.ts file.

Summary by CodeRabbit

Documentation
- Enhanced the "Buy Me A Coffee" link in README.md and README_en-US.md with a more sophisticated button link.
Bug Fixes
- Corrected the vnp_Amount property calculation in the VNPay class by removing unnecessary division by 100.
Chores
- Added a comment specifying the payment amount in the ReturnQueryFromVNPay type.

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
vnpay	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 2, 2024 1:20pm

coderabbitai[bot] commented 2 months ago

Walkthrough

The updates primarily improve the documentation and fix a significant bug. The README.md and README_en-US.md files now feature a more sophisticated "Buy Me A Coffee" button link. A documentation comment specifying the payment amount was added to the ReturnQueryFromVNPay type. The most critical fix involves removing an erroneous division by 100 in the VNPay class, which caused signature mismatches during URL verification.

Changes

Files	Change Summary
`README.md`, `README_en-US.md`	Replaced the "Buy Me A Coffee" image link with a new button link.
`src/types/return-from-vnpay.type.ts`	Added a comment in English specifying the payment amount in the `ReturnQueryFromVNPay` type.
`src/vnpay.ts`	Removed the division operation by 100 on the `vnp_Amount` property to fix signature mismatches.

Assessment against linked issues

Objective (#)	Addressed	Explanation
Incorrect signature hash during verify return URL (#15)	✅

[!TIP]

Early access features: enabled
We are currently testing the following features in early access: - **OpenAI `gpt-4o` model for code reviews and chat**: OpenAI claims that this model is better at understanding and generating code than the previous models. We seek your feedback over the next few weeks before making it generally available. Note: - You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file. - Please join our [Discord Community](https://discord.com/invite/GsXnASn26c) to provide feedback and report issues. - OSS projects are currently opted into early access features by default.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

sourcery-ai[bot] commented 2 months ago

Reviewer's Guide by Sourcery

This pull request addresses a bug where the signature verification failed due to an incorrect amount calculation. The fix involves removing the division operation on vnp_Amount before verifying the signature. Additionally, the 'Buy Me A Coffee' button in the README files has been updated to use a new image source and styling. An English comment was also added for the vnp_Amount field in the type definition.

File-Level Changes

Files	Changes
`README.md` `README_en-US.md`	Updated the 'Buy Me A Coffee' button to use a new image source and styling in both README files.
`src/vnpay.ts` `src/types/return-from-vnpay.type.ts`	Fixed the signature verification issue by removing the division operation on vnp_Amount and added an English comment for the vnp_Amount field.