search

leibler / dokuwiki-plugin-todo

DokuWiki ToDo Plugin
39 stars 30 forks source link

Allow PHP's use_strict mode #147

Closed forthommel closed 1 year ago

forthommel commented 1 year ago

This PR performs extra checks on the various variables used to ensure they are fully declared before usage. This can be useful for PHP versions >= 8 where strict mode is enforced.

einhirn commented 1 year ago

Can an option be empty? If an argument was not given it shouldn't be in the list of options.

I guess so, since we're only doing a simple "explode" on the options string. If someone just added two or more consecutive spaces there probably will be empty options which should probably just be skipped, as proposed.

@runout-at if you agree I'd be fine with merging this...

runout-at commented 1 year ago

ok for me. I didn't consider the case of multiple spaces.