search

leibovic / pocket-panel

Firefox for Android add-on to add a Pocket panel to your home screen.
9 stars 3 forks source link

After removing the dynamic panel, the add-on is still displayed in about:addons #4

Open ghost opened 9 years ago

ghost commented 9 years ago

Steps to reproduce:

  1. Open addons.mozilla.org and install pocket hits panel
  2. Go to Settings -> Customize -> Home
  3. Tap the "Pocket Hits" panel and choose "Remove"
  4. Go to about:addons

Actual result:

The add-on is still displayed in the list and I am able to log in/log out, enable/disable it, even though the panel is not present in the about:home.

Expected result:

The add-on should not be present in the list, after removing it from settings
amicalmant commented 9 years ago

Hey! Is this bug fixed or not? Tks.

ghost commented 9 years ago

The add-on is still displayed in about:addons and I am able to log in/log out, enable/disable it, even though the panel is not present in the about:home.

leibovic commented 9 years ago

This bug isn't fixed. In order for the add-on to uninstall itself when the panel is removed, you can follow the logic in here: https://github.com/mozilla/firefox-for-android-addons/blob/master/boilerplate/hub-boilerplate/bootstrap.js#L44

I don't think this is a show-stopper of a bug, since you can still just uninstall the add-on in about:addons (and if you do that without removing the panel first, the panel will be removed automatically).