leidenwarper / mapwarper

Map Warper for Leiden Archives
MIT License
2 stars 2 forks source link

other issues #15

Open erfgoedleiden opened 7 years ago

erfgoedleiden commented 7 years ago

Could you remove, from the home page: -Overview P3 -Button UPLOAD EEN KAART! -'Wat is het'-section -Tags -News -Recent gegeorefereerde kaarten+table -Recente mozaïeken+table

erfgoedleiden commented 7 years ago

Could you remove year from the Titel column in the table? It is already mentioned in the column Year.

jaar
timwaters commented 7 years ago

:+1:

erfgoedleiden commented 7 years ago

Since we ar not using Tags, could you remove the Tag-field from the 'Upload kaart' form, and the search-fields?

timwaters commented 7 years ago

We're not using tags as they are being used in mapwarper.net, but we are using them. Tags are being imported from the metadata from the "techniek" column

http://warper.erfgoedleiden.nl/maps/tag?id=Litho

and are also shown in the map detail under the description

erfgoedleiden commented 7 years ago

Rechtehbbende is supposed to be Rechthebbende

schermafbeelding 2016-12-20 om 11 18 07
erfgoedleiden commented 7 years ago

http://warper.erfgoedleiden.nl/imports If I choose 'Importeer CSV' (logged in as superuser) I'm redirected to the homepage and I get the message 'Sorry, u heeft geen toestemming om dat te zien.' (You don't have permission)

timwaters commented 7 years ago

http://warper.erfgoedleiden.nl/imports If I choose 'Importeer CSV' (logged in as superuser) I'm redirected to the homepage and I get the message 'Sorry, u heeft geen toestemming om dat te zien.' (You don't have permission)

Ahh turns out the super user didn't have the "editor" role which is used for uploading GCP csvs http://warper.erfgoedleiden.nl/users/1/roles

I have added this

timwaters commented 7 years ago

Rechtehbbende is supposed to be Rechthebbende

This has been fixed in the code and in the server...although it still needs to be edited for the already imported maps

erfgoedleiden commented 7 years ago

Thanks, I'll fix that. :) Do you know how I can delete maps?

timwaters commented 7 years ago

@erfgoedleiden what did you think about the tags being used?

timwaters commented 7 years ago

Do you know how I can delete maps?

To delete maps, go to a map page, click edit tab e.g. http://warper.erfgoedleiden.nl/maps/4#Wijzig_tab find the delete link

I've created a new issue to make it easier: https://github.com/leidenwarper/mapwarper/issues/16 "Make it easier to delete maps from an import"

erfgoedleiden commented 7 years ago

Hi Tim, Could you remove the tags everywhere? Thanks! Ellen

timwaters commented 7 years ago

Will create a new issue https://github.com/leidenwarper/mapwarper/issues/17 Remove tags for this - as "tags" are being used during import

erfgoedleiden commented 7 years ago

There are images that date before 1600. It is not possible to register those dates in the field 'Publicatiedatum' Can the year-field be set to >1500?

schermafbeelding 2016-12-20 om 13 02 55
timwaters commented 7 years ago

Can the year-field be set to >1500?

@erfgoedleiden It looks the 1600 is hardcoded, but is needed for this type of date inputs in the form.

What would be the earliest year for this ? 700 for Mappa Mundi maps or 1500? I imagine the Julian / Gregorian calendar change could complicate things, ultimately.

timwaters commented 7 years ago

Can the year-field be set to >1500?

This should now be fixed with 840865746675fccd6c1447b59a678e478ddb5f06

erfgoedleiden commented 7 years ago

Thank you! 👍

timwaters commented 7 years ago

:christmas_tree:

erfgoedleiden commented 7 years ago

:star2:

erfgoedleiden commented 7 years ago

Hi Tim, If you want to make a new layer/mosaic (http://warper.erfgoedleiden.nl/layers/new), it is possible to choose layers from the column on the right. It is possible to select the last 9 maps from 'My maps'. How can I select other maps? If I click on 'Toon al mijn kaarten' (show all my maps), I can see other maps, but I can't add them to the layer. Best regards, Ellen

timwaters commented 7 years ago

Hi,

"my maps" should really be called "favourites" (perhaps we should change this in the site?)

You can add and remove these maps into this list by clicking the "Bewaar in Mijn Kaarten" and "Verwijder uit Mijn Kaarten" links, but some maps get automatically added:

If a user uploads a new map, this map will be added automatically into this list. If a user changes or rectifies a map which someone else uploaded, this map will also be automatically added to their own list. If an admin user adds many maps via an import, these maps will also be added to their list. E.g. for the super user: http://warper.erfgoedleiden.nl/users/1/maps

When creating a layer only your own (current logged in user) maps will be shown

When editing a layer. For normal users, only those who created the layer can edit it - unless they are a special user with the "editor" role (like you and me). Those who are "editors" can edit the layer but they will just see the layer creator's maps and not their own in that place. So, for example if I have 13 "user maps" and make a layer with 3 of those maps and you edit my layer you will see in the list my 13 maps, and not your 23 maps.

For creating a layer: I added some maps to my list and was able to see these 13 maps in the new layer page on the right hand side.

screen shot 2017-01-17 at 11 23 30-fullpage

erfgoedleiden commented 7 years ago

Georeference->Add own base map kaart_toevoegen kaart_toevoegen2


see: Georeference->Add own base map translation changes #19

erfgoedleiden commented 7 years ago

If I trie to add the Mapbox Satellite baseman (georeferencing tab)

satalite_basemap

see satellite layer not showing #20

erfgoedleiden commented 7 years ago

If you want to register:

registreren registreren_reset_wachtwoord


see user registration translation fixes #21

erfgoedleiden commented 7 years ago

After clicking the button 'Uitsnijden!' (Crop map) uitsnijden


see: crop map translation improvements #22

erfgoedleiden commented 7 years ago

In the 'Upload map' tab of


see: upload translation improvements #23

erfgoedleiden commented 7 years ago

Find maps by location (Icon doesn't fit in the pop-up)

icon to large for popup

see: geosearch popup images dont fix in popup #24

erfgoedleiden commented 7 years ago

Georeference-tab georeference


see : warp improvements , design, translation #25

erfgoedleiden commented 7 years ago

tabs

erfgoedleiden commented 7 years ago

The header I gave you doesn't have the right dimensions. Could you give me the size you need? I'll sent you a new one. header

erfgoedleiden commented 7 years ago

http://warper.erfgoedleiden.nl/maps/geosearch zoekopkaart


see: Fix Geosearch geolocate #18

timwaters commented 7 years ago

Geosearch issue is being tracked here: Fix Geosearch #18

timwaters commented 7 years ago

@erfgoedleiden

The header I gave you doesn't have the right dimensions. Could you give me the size you need? I'll sent you a new one.

http://mapwarper.net/images/header_bg.jpg http://mapwarper.net/images/header_bg.jpg

The image is a wrapping image - so it is meant to stretch and the join merges with both sides. In the mapwarper.net image, shown above, the join occurs along a river. I can do a similar thing with the Leiden map header image?

timwaters commented 7 years ago

@erfgoedleiden tabs appearing and dissappearing

tabs

These are simple "responsive" tabs. If you have a small screen then the long tabs are not shown. If you have a large monitor then all the tabs are shown. Without this, the tabs would stack on top of each other and look bad. like this:

screenshot_2017-01-19_14-43-42

timwaters commented 7 years ago

I've created issues to deal with some of these, and added the link in the comment (you can also see them https://github.com/leidenwarper/mapwarper/issues )

erfgoedleiden commented 7 years ago

Hi Tim,

I suppose that becouse of the different screen display resolutions? If you could make the merge a bit neater, that would be great. Let me know if I can help you with something.

Ellen Op 19 jan. 2017, om 15:41 heeft Tim Waters notifications@github.com<mailto:notifications@github.com> het volgende geschreven:

@erfgoedleidenhttps://github.com/erfgoedleiden

The header I gave you doesn't have the right dimensions. Could you give me the size you need? I'll sent you a new one.

[http://mapwarper.net/images/header_bg.jpg]https://camo.githubusercontent.com/69523f5f9d1f6b8ce8b6bd2b918aa61001d9bd95/687474703a2f2f6d61707761727065722e6e65742f696d616765732f6865616465725f62672e6a7067

The image is a wrapping image - so it is meant to stretch and the join merges with both sides. In the mapwarper.nethttp://mapwarper.net image, shown above, the join occurs along a river. I can do a similar thing with the Leiden map header image?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/leidenwarper/mapwarper/issues/15#issuecomment-273793261, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ANQUh_EJ4ie_y9rlD-fYBa1XztQWmwfXks5rT3YTgaJpZM4K_D_e.

klik hierhttps://www.mailcontrol.com/sr/MZbqvYs5QwJvpeaetUwhCQ== om dit bericht als SPAM te rapporteren bij Websense.


Dit e-mailbericht is uitsluitend bestemd voor de geadresseerde, en kan informatie bevatten die persoonlijk of vertrouwelijk is en niet openbaar mag worden gemaakt krachtens wet- of regelgeving of overeenkomst. Gebruik van de inhoud ervan door anderen zonder toestemming van de afzender of geadresseerde is onrechtmatig. Mocht dit e-mailbericht ten onrechte bij u terechtgekomen zijn, dan verzoeken wij u vriendelijk terstond contact met ons op te nemen via www.leiden.nl/contact.

Dit bericht is gecontroleerd op Malware door Websense. www.websense.com

erfgoedleiden commented 7 years ago

Hi Tim,

Thanks for your response. But would it be possible to hide those two tabs for larger screen resolutions as well?

Best regards,

Ellen

Op 19 jan. 2017, om 15:45 heeft Tim Waters notifications@github.com<mailto:notifications@github.com> het volgende geschreven:

@erfgoedleidenhttps://github.com/erfgoedleiden tabs appearing and dissappearing

[tabs]https://cloud.githubusercontent.com/assets/13898887/22023291/db5fae4a-dcc5-11e6-98f4-0678dc1bd7ca.jpg

These are simple "responsive" tabs. If you have a small screen then the long tabs are not shown. If you have a large monitor then all the tabs are shown. Without this, the tabs would stack on top of each other and look bad. like this:

[screenshot_2017-01-19_14-43-42]https://cloud.githubusercontent.com/assets/48941/22111020/b969386a-de55-11e6-97e5-ca2084c5145a.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/leidenwarper/mapwarper/issues/15#issuecomment-273794262, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ANQUh2P4CjOI2iIl4mB-iqbmuu8HP4rJks5rT3b4gaJpZM4K_D_e.

klik hierhttps://www.mailcontrol.com/sr/MZbqvYs5QwJvpeaetUwhCQ== om dit bericht als SPAM te rapporteren bij Websense.


Dit e-mailbericht is uitsluitend bestemd voor de geadresseerde, en kan informatie bevatten die persoonlijk of vertrouwelijk is en niet openbaar mag worden gemaakt krachtens wet- of regelgeving of overeenkomst. Gebruik van de inhoud ervan door anderen zonder toestemming van de afzender of geadresseerde is onrechtmatig. Mocht dit e-mailbericht ten onrechte bij u terechtgekomen zijn, dan verzoeken wij u vriendelijk terstond contact met ons op te nemen via www.leiden.nl/contact.

Dit bericht is gecontroleerd op Malware door Websense. www.websense.com

timwaters commented 7 years ago

created

26 for header and

27 for geosearch tabs

erfgoedleiden commented 7 years ago

Hi Tim, I was testing the API, and tried to get a mask. According to the documentation http://mapwarper.net/shared/masks/{:map_id}.gml.ol should get the mask of a map. In my case, that would be http://warper.erfgoedleiden.nl/shared/masks/255.gml.ol, I guess. But I get the response "The page you were looking for doesn't exist." Could you tell me what I do wrong? Best regards, Ellen

timwaters commented 7 years ago

Ahh, this looks to be a different configuration than specified in the documentation. http://warper.erfgoedleiden.nl/mapimages/255.gml.ol should get the mask.

I can change this though!

erfgoedleiden commented 7 years ago

Hi Tim, It would be great if it has the same configuration as noted in the API description. Thanks! Best regards, Ellen

erfgoedleiden commented 7 years ago

Hi Tim, Last question :) I tried to load http://warper.erfgoedleiden.nl/mapimages/255.gml.ol in to QGIS. But the bounding box seems to lie next to Africa. Could it be that the lat and long are switched? (or it might be that the projection isn't WGS84?). Best regards, Ellen

timwaters commented 7 years ago

The coordinates of the clipping file are actually in image / pixel space of the source image, rather than the output image. The clipping file is created by the user and saved to the server. The source image is then clipped and after clipping it is then georeferenced into the output image.

Hope this makes sense!

erfgoedleiden commented 7 years ago

It does :blush: Thanks!