search

leifeld / btergm

Temporal Exponential Random Graph Models by Bootstrapped Pseudolikelihood
16 stars 10 forks source link

Added ability to pass control.ergm() to btergm #11

Closed reuning closed 5 years ago

reuning commented 5 years ago

Not sure if this is wanted but I needed to change the max dyad size so added some lines to allow you to pass control.ergm on. It probably won't be very useful outside of changing the max dyad but I wasn't sure so I made it more generic.

leifeld commented 5 years ago

Hi there! Thanks for your pull request and continued work on this. Let me know when you are done with your changes, and I'll review the changes. I think it makes sense to offer fastglm support now that it is available.

reuning commented 5 years ago

Sure. I hadn't realized that the pull request would keep updating (I'm still relatively new to actually using github). I'll let you know when it gets to a stable spot.

leifeld commented 5 years ago

Hi there. I am aiming to release a new version next weekend. It would be ideal if you could wrap up your changes by then in order to avoid any conflicts that need to be integrated into your PR. Thanks.

reuning commented 5 years ago

I'll clean things up this week.

I have it currently set so that fastglm is not the default (switched on with usefastglm=T) Do you have a preference for this?

leifeld commented 5 years ago

Great, thanks! I'd prefer to keep it that way for now in order to match the description in the article in the Journal of Statistical Software that came out last year.

reuning commented 5 years ago

There that should be everything.

leifeld commented 5 years ago

Excellent, thanks! I have made some minor changes to comply with CRAN guidelines and improve formatting. Will merge now.