Closed Dreznel closed 3 years ago
Opened this a little early, but might as well leave it for now. I'm going to mark this as "WIP" (work in progress) while I'm still adding things, then remove the label when it's ready. That way, we can review as we go.
@leifeld Done! And devtools::test()
now shows all unit tests passing. devtools::check()
looks good on my end as well (I have one "note", but it's related to something specific to my local setup so it shouldn't affect your end of things.)
Merging #23 into master will decrease coverage by
0.02%
. The diff coverage is51.51%
.
@@ Coverage Diff @@
## master #23 +/- ##
==========================================
- Coverage 36.50% 36.48% -0.03%
==========================================
Files 9 9
Lines 2657 2656 -1
==========================================
- Hits 970 969 -1
Misses 1687 1687
Impacted Files | Coverage Δ | |
---|---|---|
R/checkdegeneracy.R | 0.00% <0.00%> (ø) |
|
R/btergm.R | 62.50% <58.62%> (-0.13%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update eb68811...f85e3e4. Read the comment docs.
As specified in the associated issues, I switched out ergm::remove.offset.formula() for statnet.common::filter_rhs.formula(). I left the arguments untouched.
Additionally, I removed two deprecated functions from the NAMESPACE file after finding no references to those functions in the code.
Four unit tests, which were failing before I made any changes, are still failing.