search

leighmacdonald / gbans

gbans is a centralized game community platform with support for global bans. It currently supports Team Fortress 2
MIT License
45 stars 16 forks source link

Clientprefs support #373

Open ghost opened 1 year ago

ghost commented 1 year ago

Will there be support for clientprefs in the future?

For example there is the centerprojectiles plugin on uncletopia, if I want to keep it enabled I would have to enable it on every server I join.

I understand that this is using postreges which sourcemod also supports and I could just edit the database file for clientprefs.

leighmacdonald commented 1 year ago

I do plan to eventually support this, in a centralized manner, but its a bit more complicated than just pointing to our pg as that will only ever listen on localhost. Id prefer to implement this via the https api that we already use. Unfortunately all the salient clientprefs functionality is in an extension so its a bit more work to make happen.

Gcommer commented 5 months ago

Are you interested in a contribution here?

I feel it's something like:

Assuming the prefs are small enough it honestly wouldn't be that bad to do push-based instead -- ie send all players' prefs to every server proactively. Maybe scp it every 5 minutes? With a binary file format it would likely be a few MB max.

leighmacdonald commented 5 months ago

This was actually going to come up pretty soon, Once the sql admin stuff is in place, since it makes sense to also support this now using the same database. Database will be exposed with a limited privileged user bound only to the wireguard interface so im not too worried about it anymore. We didn't originally have this vpn network setup previously.

The plan i had was to basically just implement https://github.com/alliedmodders/sourcemod/blob/master/configs/sql-init-scripts/pgsql/clientprefs-pgsql.sql and use the built in clientprefs extension. I had no intentions of doing anything on the site itself, but it seems reasonable if you think there is some value to that. Feel free to tackle it if you want.

Gcommer commented 5 months ago

Awesome I got clientprefs pointing to my gbans psql instance and it works great with no changes to the tf2centerprojectiles plugin.

Wrote #536 based on that architecture. Other than that its probably just infra changes on your end to close this bug.