Closed regexident closed 9 years ago
@regexident I’m not Leigh (obviously), but wanted to chime in with a thank you — these are nice, well-written improvements that I’m going to merge into my fork real soon.
@regexident This PR is great, and really improves the code! Could you comment on the two things I raised (I want to make sure I'm not missing something)? I'll then merge it manually into the develop
branch.
I've got a branch on-top of your current changes that fixes the stale bookmark issue. :smile:
Hi Leigh,
the two comments of yours are 100% legitimate.
And thanks for the project in the first place! :+1:
Merged.
Hi Leigh,
I took the liberty to do apply refactorings (API compatibility not affected) and modernization cleanups.
Code Modernizations:
retain
tostrong
in properties.- (id)init…
to- (instancetype)init…
Cleanups:
Safety:
retain
tocopy
in properties with potentially mutable values.Swift compatibility:
deprecated
for the time being).Refactoring:
Unit Tests:
CocoaPods support:
Note: The CocoaPods integration still requires some steps from you:
1.0.14
for the PR merge commit.$ pod spec lint AppSandboxFileAccess.podspec
in your project directory.