leighmcculloch / AppSandboxFileAccess

A class that wraps up writing and accessing files outside a Mac apps App Sandbox files into a simple interface. The class will request permission from the user with a simple to understand dialog consistent with Apple's documentation and persist permissions across application runs.
BSD 2-Clause "Simplified" License
114 stars 23 forks source link

Lots of small improvements. (Detailed list & explanation inside.) #4

Closed regexident closed 9 years ago

regexident commented 9 years ago

Hi Leigh,

I took the liberty to do apply refactorings (API compatibility not affected) and modernization cleanups.

Code Modernizations:

Cleanups:

Safety:

Swift compatibility:

Refactoring:

Unit Tests:

CocoaPods support:

Note: The CocoaPods integration still requires some steps from you:

  1. Add a tag 1.0.14 for the PR merge commit.
  2. Run $ pod spec lint AppSandboxFileAccess.podspec in your project directory.
  3. Run `$ pod trunk push in your project directory.
vslavik commented 9 years ago

@regexident I’m not Leigh (obviously), but wanted to chime in with a thank you — these are nice, well-written improvements that I’m going to merge into my fork real soon.

leighmcculloch commented 9 years ago

@regexident This PR is great, and really improves the code! Could you comment on the two things I raised (I want to make sure I'm not missing something)? I'll then merge it manually into the develop branch.

I've got a branch on-top of your current changes that fixes the stale bookmark issue. :smile:

regexident commented 9 years ago

Hi Leigh,

the two comments of yours are 100% legitimate.

And thanks for the project in the first place! :+1:

leighmcculloch commented 9 years ago

Merged.