Tags for each unison and ocaml version

[leighmcculloch]

A continuation of #13, but changing the build process to continue to use Docker Hub's automated builds.

[leighmcculloch]

@nalipaz What do you think?

[nalipaz]

I don't see any changes actually... https://github.com/nalipaz/docker-unison/compare/master...leighmcculloch:tags-for-each-unison-and-ocaml-version

[nalipaz]

Fixed my bad link above, but I am looking at commit now

[leighmcculloch]

@nalipaz You need to switch the two in that comparison. Your branch is entirely within my branch, therefore it shows no difference.

[leighmcculloch]

I've created these test build tags, that are similar to how it will look like in the Docker Hub configuration for the next version, except the test and the branch name will be replaced with 1.1.0:

Once they finish building could you try out the build that you use? They have a test- prefix then with unison and ocaml versions within.

[leighmcculloch]

@nalipaz Which tag is the one you use, and could you try running it to make sure it still works? https://hub.docker.com/r/leighmcculloch/unison/tags/ I'm testing the norm Mac one at the moment.

[nalipaz]

I use unison 2.48.3 with ocaml 4.01. I can destroy my vagrant machine and run a provision a new one with your tag to see what happens. Give me a few.

[leighmcculloch]

Something aint working for me. I can't seem to connect to the container.

[nalipaz]

Yes, I just built a new machine and I get the:

Contacting server...
Fatal error: Lost connection with the server

when running unison commands.

I have not investigated further.

[nalipaz]

oh, btw, I am able to use docker exec to enter the container.

[leighmcculloch]

Attaching to the container shows:

runsv unison: fatal: unable to start ./run: access denied                                      

[nalipaz]

hmm, odd. I was looking over the logs: https://hub.docker.com/r/leighmcculloch/unison/builds/bkedvvytjpeek82que9vysq/

They look alright from what I can tell. And the build I have sitting on quay.io is pretty much the same minus getting rid of travis in favor of docker's hub.

[nalipaz]

It is late here, but I will look again tomorrow. Sorry I have to run off for now.

[leighmcculloch]

No worries. Okay, I think I found someone who had the same issue. The exec inside the service run script may be the issue. I'll post what I find, I've got to head to bed soon too :).

[leighmcculloch]

No joy, problem still happens. I'll look at it more over the next few days. I think we're close though.

[leighmcculloch]

Fixed in the last commit. Take a look, the file needed to be moved. I've tested locally and it works perfectly for me. When you get a chance to test your version, if it works, then I'll merge this and tag the new version and update the latest tag.

[nalipaz]

@leighmcculloch I was able to successfully use tag test-unison2.48.3-ocaml4.01. The only way I can think to test the others would involve provisioning some docker machines or perhaps some virtualmachines. I think however it is more than likely good to go.

[leighmcculloch]

Yup I think it's good to go if at least these versions are working. If there are reports of problems then I'll look into it. Will get this in a version soon.

[nalipaz]

LGTM

[nalipaz]

Hurray!

[nalipaz]

@leighmcculloch I just provisioned a new container off of the image leighmcculloch/unison:latest-unison2.48.3-ocaml4.01 and it worked beautifully, and sync worked perfectly.

This is great!

[leighmcculloch]

@nalipaz Woohoo! 😄

[leighmcculloch]

@nalipaz Thanks for your amazing work in reorganizing the container and the Dockerfile. It's s much neater!

[nalipaz]

It was fun! lol. Thanks for being receptive and collaborating.