search

leikind / wice_grid

A Rails grid plugin to create grids with sorting, pagination, and (automatically generated) filters
MIT License
537 stars 215 forks source link

Get rid of Kaminari #174

Open leikind opened 9 years ago

leikind commented 9 years ago

Implement pagination inside the plugin. Ain't no rocket science.

afdev82 commented 8 years ago

I think it would be better to leave the choice to the user. We are already using kaminari in our project and we want to have one code for the pagination. For this reason, it would be helpful to have a config option to specify the kaminari theme, to switch to the default (or other custom theme), instead of the wice_grid one.

leikind commented 8 years ago

I will refer you to (1) this http://www.mikeperham.com/2016/02/09/kill-your-dependencies/, (2) this https://github.com/amatsuda/kaminari/pull/267 (3) and this ugly hack https://github.com/leikind/wice_grid/blob/rails3/lib/wice/kaminari_monkey_patching.rb

If WiceGrid does pagination by itself, what do you care? You just continue using Kaminari.

Having said that, I am not going to do this. I am tired of supporting this project for more than 6 years (https://www.mail-archive.com/rubyonrails-talk@googlegroups.com/msg44536.html) and I am looking for other maintainers.

afdev82 commented 8 years ago

I read the provided links. I agree with them. My issue was only not to have the theme for the pagination hardcoded, but to have an option to opt-out and choose another theme instead of the wice_grid one.

leikind commented 8 years ago

if i did this I'd leave the markup the same