search

leikind / wice_grid

A Rails grid plugin to create grids with sorting, pagination, and (automatically generated) filters
MIT License
537 stars 215 forks source link

Hi I added some things xD #238

Closed ryanfox1985 closed 8 years ago

ryanfox1985 commented 8 years ago

I added Rspec test. Fixed rubocop config.

ryanfox1985 commented 8 years ago

Now travisCI check the commits xD good! Please execute rake and open coverage/index.html.

ryanfox1985 commented 8 years ago

Some offenses from rubocop accept auto-correct xD.

leikind commented 8 years ago

Tell me, why do you believe everything Rubocop tells you is the ultimate truth? This is some kind of cargo cult you are blindly following. Some rules it insists on are stupid and brain damaged

leikind commented 8 years ago

for example it wants to autocorrect my code like this:

  row_content = if replace_row_output
    no_rightmost_column = true
    replace_row_output
  else
    row_content, tmp_cell_value_of_the_ordered_column = get_row_content(rendering,ar,sorting_dependant_row_cycling)
    cell_value_of_the_ordered_column = tmp_cell_value_of_the_ordered_column if tmp_cell_value_of_the_ordered_column
    row_content
                end

Or it insists on not naming methods like "has_xyq?"

How the hell does it help? What kind of idiocy is it?

I am merging your commits, and then I will revert the rubocop config back to my version. I ain't following no cargo cult religions.