search

leikind / wice_grid

A Rails grid plugin to create grids with sorting, pagination, and (automatically generated) filters
MIT License
537 stars 213 forks source link

Revised configs. #245

Closed ryanfox1985 closed 9 years ago

ryanfox1985 commented 9 years ago

Rubocop fails not affect to travis. Removed extensions. Added test.

leikind commented 9 years ago

i think I merged it already https://github.com/leikind/wice_grid/commits/development

btw I merged a branch into 'development' which changes the API and removes some ugly old code https://github.com/leikind/wice_grid/blob/development/CHANGELOG.md#360

ryanfox1985 commented 9 years ago

Hey why you don't merge mi code?

leikind commented 9 years ago

Why do you push to a feature branch at all? Please don't. The branch to work on is development.

leikind commented 9 years ago

I am reverting your variable renaming in wice_grid_misc.rb. I wrote this code just the other day and I have my reasons to call that variable precisely this way. It has to do with the functionality I am adding, and not the immediate data types that you are seeing.