search

leikind / wice_grid

A Rails grid plugin to create grids with sorting, pagination, and (automatically generated) filters
MIT License
537 stars 215 forks source link

Fixed offense array. #259

Closed ryanfox1985 closed 8 years ago

ryanfox1985 commented 8 years ago

Hi again xD.

leikind commented 8 years ago

What is an offense array?

ryanfox1985 commented 8 years ago

yes, the standard is %w(a b c)

2015-10-17 20:46 GMT+02:00 Yuri Leikind notifications@github.com:

What is an offense array?

— Reply to this email directly or view it on GitHub https://github.com/leikind/wice_grid/pull/259#issuecomment-148942416.

leikind commented 8 years ago

what is the point of this commit?

ryanfox1985 commented 8 years ago

xD I fixed a Rubocop offense. Well recently I update your gem and it's great. Goood job.

Regards.

2015-10-17 22:50 GMT+02:00 Yuri Leikind notifications@github.com:

what is the point of this commit?

— Reply to this email directly or view it on GitHub https://github.com/leikind/wice_grid/pull/259#issuecomment-148950199.

leikind commented 8 years ago

This project is in need of real work and real changes, and replacing ['a', 'b'] by %w(a b) is not what this project needs, it solves 0 problems. I will not accept such pull requests. This is not a contribution.

ryanfox1985 commented 8 years ago

mmmm you doesn't remember that I added Rubocop, TDD with Rspec and the readme? Travis etc.

2015-10-17 23:19 GMT+02:00 Yuri Leikind notifications@github.com:

This project is in need of real work and real changes, and replacing ['a', 'b'] by %(a b) is not what this project needs, it solves 0 problems. I will not accept such pull requests. This is not a contribution.

— Reply to this email directly or view it on GitHub https://github.com/leikind/wice_grid/pull/259#issuecomment-148952810.

leikind commented 8 years ago

I do remember. And I have always been against using all Rubocop cops. This is silly. This is not software development. This is masturbation.

Software development is adding features, improving featurs, fixing bugs. This project is is need of these. It doesn't need 100500 commits to replace ['a', 'b', 'c'] by %w(a b c) to conform to some braindead code standards.

ryanfox1985 commented 8 years ago

Which editor you use editor you use to develop RoR? Rubymine also detect this.

2015-10-17 23:28 GMT+02:00 Yuri Leikind notifications@github.com:

I do remember. And I have always been against using all Rubocop cops. This is silly. This is not software development. This is masturbation.

Software development is adding features, improving featurs, fixing bugs. This project is is need of these. It doesn't need 100500 commits to replace ['a', 'b', 'c'] by %w(a b c) to conform to some braindead code standards.

— Reply to this email directly or view it on GitHub https://github.com/leikind/wice_grid/pull/259#issuecomment-148953369.

leikind commented 8 years ago

You are confusing a tool for a goal. Rubymine, rubocop, CI, and so on are tools. They are not goals.

ryanfox1985 commented 8 years ago

Well tell me what is the roadmap? I interested to contribute to your library.

2015-10-17 23:35 GMT+02:00 Yuri Leikind notifications@github.com:

You are confusing a tool for a goal. Rubymine, rubocop, CI, and so on are tools. They are not goals.

— Reply to this email directly or view it on GitHub https://github.com/leikind/wice_grid/pull/259#issuecomment-148953676.

leikind commented 8 years ago

https://github.com/leikind/wice_grid/issues?q=is%3Aopen+is%3Aissue+label%3A%22to+do%22