search

leikind / wice_grid

A Rails grid plugin to create grids with sorting, pagination, and (automatically generated) filters
MIT License
536 stars 215 forks source link

Making query respect uppercases present in table names (for legacy da… #290

Closed ablancag closed 8 years ago

ablancag commented 8 years ago

…tabases).

Based on 3.2.1 since that's the version in use.

Signed-off-by: Alex Blanca alex.blanca@gmail.com

leikind commented 8 years ago

Hey

Sorry it has taken so long.

Can you please re-do this based on HEAD so that it can be merged automatically?

leikind commented 8 years ago

done thanks

leikind commented 8 years ago

Your fix is PostgreSQL specific, doesn't respect other DBs and renders generated SQL invalid. I rolled back your change.

I myself have spent the last year using PostgreSQL and it was rather silly of me to accept the PR in the first pace, my bad

ablancag commented 8 years ago

Would you be interested if I found a way of detecting whether PostgreSQL is the database in use or not?

Don't know yet if possible, but could work.

Alex B.

On Sun, Apr 17, 2016 at 5:10 AM, Yuri Leikind notifications@github.com wrote:

Your fix is PostgreSQL specific, doesn't respect other DBs and renders generated SQL invalid. I rolled back your change.

I myself have spent the last year using PostgreSQL and it was rather silly of me to accept the PR in the first pace, my bad

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/leikind/wice_grid/pull/290#issuecomment-210990859

leikind commented 8 years ago

There is already this code somewhere deep in ActiveRecord for escaping table names in SQL commands

ablancag commented 8 years ago

Ah. Is there?

Let me see what I find and will let you know.

Regards,

Alex B.

On Sun, Apr 17, 2016 at 10:55 AM, Yuri Leikind notifications@github.com wrote:

There is already this code somewhere deep in ActiveRecord for escaping table names in SQL commands

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/leikind/wice_grid/pull/290#issuecomment-211046902