leikind / wice_grid

A Rails grid plugin to create grids with sorting, pagination, and (automatically generated) filters
MIT License
536 stars 215 forks source link

Make rubo cop not fail #298

Closed noahc closed 8 years ago

noahc commented 8 years ago

WIP

Trying to fix all Rubocop warnings. Will Continue working on this tomorrow.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 38.66% when pulling b37aa498cb16875cee6c9f2c35b1c89523d69415 on noahc:make-rubo-cop-not-fail into 9dfd233b2f9f2a1bf550364f42a3ea5d6fe4fb6e on leikind:rails3.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 38.66% when pulling ab2a318d73ac43f2d24720becc4dc91509bb98cb on noahc:make-rubo-cop-not-fail into 9dfd233b2f9f2a1bf550364f42a3ea5d6fe4fb6e on leikind:rails3.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 38.66% when pulling bb270e60eb760f17ac2bb1e267feb7523d110b98 on noahc:make-rubo-cop-not-fail into 9dfd233b2f9f2a1bf550364f42a3ea5d6fe4fb6e on leikind:rails3.

leikind commented 8 years ago

You are wasting your time on useless things

noahc commented 8 years ago

Would it be better to remove Rubocop then?

I'm trying to clean up the edges around the test output so my self and others can have increased confidence in a code base we're unfamiliar with. I agree that these changes aren't that significant, but they are the first small steps in getting the code base to a point where those unfamiliar with the code base can work with it with confidence.

Do you disagree?

leikind commented 8 years ago

If wouldn't object to removing Rubocop.

jdickey commented 8 years ago

How about, instead, just creating a .rubocop.yml file that disables the cops you don't (yet) care about?

I've found on a couple of dozen projects (and counting) that RuboCop is one of my three or four pieces of dead-finger tech (along with Flog, Flay, Reek, and Inch). YMMV, but I just thought I'd put in a word.

leikind commented 8 years ago

I am not spending my time on this useless pursuit.