search

leikind / wice_grid

A Rails grid plugin to create grids with sorting, pagination, and (automatically generated) filters
MIT License
536 stars 215 forks source link

fix deprecation warning #302

Closed bvogel closed 8 years ago

bvogel commented 8 years ago

fix for #301

leikind commented 8 years ago

Thank you, I appreciate this contribution! 👍

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.6%) to 38.074% when pulling 44ffa8a9d62b28c63fa4106630147fe9d3a07326 on bvogel:rails3 into 8002703a0c76ea7ad05710abfe781ed37ceff040 on leikind:rails3.

noahc commented 8 years ago

Do you have plans to release this to ruby gems or should I point my project to the rails3 branch?

leikind commented 8 years ago

@noahc https://rubygems.org/gems/wice_grid/versions/3.6.1

leikind commented 8 years ago

@noahc oops. It's a broken build

ERROR:  While executing gem ... (Gem::DependencyError)
    Unable to resolve dependencies: actionview requires activesupport (= 4.2.6); railties requires activesupport (= 5.0.0.rc1); kaminari requires activesupport (>= 3.0.0); actionpack requires activesupport (= 5.0.0.rc1), rack (~> 2.x), actionview (= 5.0.0.rc1); rails-dom-testing requires activesupport (< 5.0, >= 4.2.0.beta); rails-deprecated_sanitizer requires activesupport (>= 4.2.0.alpha); activerecord requires activesupport (= 4.2.6); activemodel requires activesupport (= 4.2.6)
leikind commented 8 years ago

unpublished 3.6.1

noahc commented 8 years ago

Thanks!

Saw 3.6.2 was live.

leikind commented 8 years ago

it was my local error. It should be fine

On Wed, Jun 15, 2016 at 9:34 PM, Noah Clark notifications@github.com wrote:

Thanks!

Saw 3.6.2 was live.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/leikind/wice_grid/pull/302#issuecomment-226295627, or mute the thread https://github.com/notifications/unsubscribe/AAGDwmrPhM23N5bqEQOMYFNr6rqKE71vks5qMFO1gaJpZM4Iz24p .

Best regards, Yuri Leikind

Sent from my Nokia 3310