search

leikind / wice_grid

A Rails grid plugin to create grids with sorting, pagination, and (automatically generated) filters
MIT License
536 stars 215 forks source link

[Rails5] Fix missing parameters in column links #324

Closed harryPL closed 7 years ago

harryPL commented 7 years ago

My previous PR was using the method .to_h of ActionController::Parameters object which fixed the problem of not rendering the grid and removed the deprecation warnings. While fixing one problem it introduced another: it removed all unpermitted parameters from the params hash, including the params for the grid (filtering, ordering). Using .to_unsafe_h removes this issue as it preserves all the params for the grid.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 37.512% when pulling 74ef1e7dec2e0da8dfce97d15f62080f33a3a41c on harryPL:rails3 into e8a923ec041c0c97adeac48eb1ee5d47490297fd on leikind:rails3.