Wice_grid not loaded script to Javascript

leikind / wice_grid

A Rails grid plugin to create grids with sorting, pagination, and (automatically generated) filters

MIT License

536 stars 215 forks source link

Wice_grid not loaded script to Javascript #331

Closed golddiga closed 7 years ago

golddiga commented 7 years ago

the commit is addressing the "$ not defined error" that i also expierienced https://github.com/leikind/wice_grid/issues/82

coveralls commented 7 years ago

Coverage increased (+0.5%) to 37.98% when pulling 05fe6f3a7dce65e0489a9a16abe6bf2a550fdd3e on golddiga:rails3 into 0d7348fa16d1041eea984987b752e735432728fd on leikind:rails3.

leikind commented 7 years ago

WiceGrid relies on jQuery. It is explicitly mentioned in the documentation. Add jQuery and it'll be fine.

You pull request removes one completely valid use of jQuery leaving others in place.

I am not merging this of course.

golddiga commented 7 years ago

Im using jquery but, as many of the users, I don't load jQuery in the head. so $ is not defined yet when you insert this script. you even suggested to replace this code with pure javascript in this issue. https://github.com/leikind/wice_grid/issues/82

leikind commented 7 years ago

oops completely forgot my bad