search

leikind / wice_grid

A Rails grid plugin to create grids with sorting, pagination, and (automatically generated) filters
MIT License
535 stars 215 forks source link

Fix undefined method `to_unsafe_h' for nil:NilClass #341

Closed kreintjes closed 7 years ago

kreintjes commented 7 years ago

Oops, apparently I failed in my previous PR (https://github.com/leikind/wice_grid/pull/340). Instead of giving a deprecation warning, WiceGrid now crashes on Rails 5 when having no filters. Since this does not seem desired behaviour, or at least is not desired by me, I have updated my fix. My apologies for the inconvenience.

leikind commented 7 years ago

thx

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.04%) to 37.452% when pulling ada2f3ed9bbdfee8fecac8518cef6fce91d7d8de on kreintjes:fix/rails-5-crash into 4bb139e3e9d812f0365b5fb538363bac1c8e58eb on leikind:rails3.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.04%) to 37.452% when pulling ada2f3ed9bbdfee8fecac8518cef6fce91d7d8de on kreintjes:fix/rails-5-crash into 4bb139e3e9d812f0365b5fb538363bac1c8e58eb on leikind:rails3.