Bugfix: replace WiceGridController#send_file_rails2 with Rails' send_file

leikind / wice_grid

A Rails grid plugin to create grids with sorting, pagination, and (automatically generated) filters

MIT License

535 stars 215 forks source link

Bugfix: replace WiceGridController#send_file_rails2 with Rails' send_file #342

Closed kreintjes closed 2 weeks ago

kreintjes commented 7 years ago

Fixes issue when trying to download a CSV export in combination with Turbolinks 5 (issue #326, credits to @nathanvda for the fix) and fixes Rails 5 deprecation warning concerning render :text.

coveralls commented 7 years ago

Coverage increased (+0.2%) to 37.653% when pulling 5896103ce633566befc119f7126a063c364f97d1 on kreintjes:fix/csv-file-download into f065b915ed29108fbd0e1286798b005691e505ad on leikind:rails3.

coveralls commented 7 years ago

Coverage increased (+0.2%) to 37.653% when pulling 5896103ce633566befc119f7126a063c364f97d1 on kreintjes:fix/csv-file-download into f065b915ed29108fbd0e1286798b005691e505ad on leikind:rails3.

coveralls commented 7 years ago

Coverage increased (+0.2%) to 37.653% when pulling 335c239a5ef9e10a92356fbc0484deb145aeae6b on kreintjes:fix/csv-file-download into f065b915ed29108fbd0e1286798b005691e505ad on leikind:rails3.

coveralls commented 7 years ago

Coverage increased (+0.2%) to 37.653% when pulling eaeb12e3b3bfd135934c5ac0e0ce0ce749015b9e on kreintjes:fix/csv-file-download into f065b915ed29108fbd0e1286798b005691e505ad on leikind:rails3.

dima4p commented 2 weeks ago

The first file is fixed in 50b7247c8c. The second is not required for the version 6.1.3.