search

leil-io / saunafs

SaunaFS is a free-and open source, distributed POSIX file system inspired by Google File System.
https://saunafs.com
GNU General Public License v3.0
52 stars 5 forks source link

fix(uraft): Fix missing floating ip address #164

Closed uristdwarf closed 4 weeks ago

uristdwarf commented 1 month ago

If something removes the floating ip address from the device, saunafs-uraft will not bring it back. For example, on Ubuntu systems, if systemd-networkd is restarted, it will reapply netplan config, which inadvertently remove the floating ip address, and uraft has no way of adding this back.

This fix adds a way for uraft to bring the IP address back. First by exporting the IP address as an environment variable in the main program, and then by using in the script to query iproute2 for the IP address, and add it when it's missing.

Note that if two IP addresses with different subnet masks are added, then it won't re-add the IP address with the correct subnet mask.

uristdwarf commented 4 weeks ago

The only failing test worked locally, likely the CI VM was overloaded with the build tests

image

So I'll merge it since it's very unlikely this change broke anything.