Accessibility issues - Githubissues

leinardi / FloatingActionButtonSpeedDial

A Floating Action Button Speed Dial implementation for Android that follows the Material Design specification (https://material.io/components/buttons-floating-action-button#types-of-transitions)

Apache License 2.0

1.46k stars 140 forks source link

Accessibility issues #149

Closed flocke closed 3 years ago

flocke commented 4 years ago

I use the SpeedDial in my project (https://github.com/andOTP/andOTP) and a user recently opened an issue regarding the accessibility of the app which included some comments regarding the FAB menu. I was able to fix some of them myself, but there are still some things left which should be handled by the menu itself:

When the FAB is pressed and the overlay shown:
- One of the options displayed should be focused;
- The user should not be able to swipe to any of the user interface elements that are hidden behind the overlay;
- Focusing the FAB or overlay should indicate that activating will close the overlay, whereas currently the FAB is unlabelled and the overlay reports nothing.
- The smaller FAB buttons of the menu should have their content description set to the value of the label

You can find the original issue here: https://github.com/andOTP/andOTP/issues/498

leinardi commented 4 years ago

Hi @flocke, I should have fixed all the issues (or provided a way to fix them downstream). Could you please have a look at the PR and let me know what you think?

flocke commented 3 years ago

@leinardi Thank you for implementing this, I have to apologize for being so slow to review it. I must admit that I totally forgot about this issue...

I took your changes for a spin in andOTP and it seems like they are working nicely.

There are only two things I found that could be problematic:

If you focus the overlay there is no content description, it can be set downstream by calling the setContentDescription() function on the overlay. But maybe a default description for the overlay would be nice (maybe the same as the "Close menu" button, since clicking it has the same function of dismissing the menu).
I managed to swipe "behind the overlay" after focusing it and access the content of the app behind it while the menu is still open. We should either prevent that, or close the menu when that happens.

fei0316 commented 3 years ago

Any updates on when this will be included in a release?

leinardi commented 3 years ago

Hi @fei0316 I'm trying to have a new release over this weekend.

leinardi commented 3 years ago

Release 3.2.0 is available on Maven Central: https://repo1.maven.org/maven2/com/leinardi/android/speed-dial/maven-metadata.xml