Fix off-by-one error in column positions - Githubissues

leinardi / mypy-pycharm

A plugin providing both real-time and on-demand scanning of Python files with Mypy from within PyCharm/IDEA.

Apache License 2.0

188 stars 30 forks source link

Fix off-by-one error in column positions #79

Closed intgr closed 2 years ago

intgr commented 2 years ago

Mypy uses 1-based column numbers, IntelliJ expects 0-based.

This got confusing in some situations, the highlight would appear in the wrong place for example when using single-letter variable names.

Before	After

Contributor checklist

[x] I am using the provided codeStyleConfig.xml
[x] I have tested my contribution on these versions of PyCharm/IDEA:
- PyCharm Community 2021.2.3
[x] My contribution is fully baked and ready to be merged as is
[x] I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Description

Type of Changes

	Type
✓	:bug: Bug fix

leinardi commented 2 years ago

Thank you for the bug fix!