Create intention to suppress Mypy errors

leinardi / mypy-pycharm

A plugin providing both real-time and on-demand scanning of Python files with Mypy from within PyCharm/IDEA.

Apache License 2.0

188 stars 30 forks source link

Create intention to suppress Mypy errors #81

Closed intgr closed 2 years ago

intgr commented 2 years ago

This was trickier than expected, but seems to work. :)

Kooha-12-05-2021-22-10-38

Contributor checklist

[x] I am using the provided codeStyleConfig.xml
[x] I have tested my contribution on these versions of PyCharm/IDEA:
- PyCharm Community 2021.2.3
[x] My contribution is fully baked and ready to be merged as is
[x] I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Description

Type of Changes

	Type
✓	:sparkles: New feature

Related Issue

As discussed in #77.

leinardi commented 2 years ago

Oh wow this is impressive! Thanks a lot!

intgr commented 2 years ago

Unfortunately using the intention from the 'Code -> Inspect Code...' tool does not work.

leinardi commented 2 years ago

Should I proceed with a new release?

intgr commented 2 years ago

Unfortunately using the intention from the 'Code -> Inspect Code...' tool does not work.

I think that's because IntelliJ again confusingly has two different APIs for doing the same thing -- LocalQuickFix vs IntentionAction (latter used here).

Anyway I don't feel like investigating that right now. The current implementation works well enough for me. :)

Should I proceed with a new release?

Sure. I don't think the above should be a release blocker.

leinardi commented 2 years ago

Hey, you did a lot for this project, if you want I would be happy give you the Contributor role to the project, let me know if you'll be interested :-)

intgr commented 2 years ago

if you want I would be happy give you the Contributor role to the project

Sure, thanks. I don't feel like I need any special privileges, the current pull request process works well. But I will have a vested interest in this project going forward as well, and can help out with PR code reviews or other tasks.

leinardi commented 2 years ago

Thanks! As you probably have notice, I'm not very active anymore on this project, so I would really appreciate some external contributions!

I just sent you an invitation :+1:

And I also just released version 0.12.0 :tada: https://github.com/leinardi/mypy-pycharm/releases/tag/0.12.0

The plugin is under review and should become available in the next 2 days.

intgr commented 2 years ago

As you probably have notice, I'm not very active anymore on this project

Just out of curiosity, do you still use it regularly?

leinardi commented 2 years ago

Regularly? No, I'm an Android developer as my daily job so I work with Kotlin and Java, not Python. I work with Python only when I develop my Linux applications and lately I do not have much time for it.

I wrote these 2 plugins when I started working with Python, because I was used to CheckstyleIDEA for Java. But nowadays I do not use them very often since my linux apps are basically in maintenance mode.